[Updated] D11882: rhg: fix a crash on non-generaldelta revlogs

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  Looks good aside from the docstrings needing to be docstrings or absorbed

INLINE COMMENTS

> index.rs:21
>  
> -// Corresponds to the high bits of `_format_flags` in python
> +/// Corresponds to the high bits of `_format_flags` in python
>  impl IndexHeaderFlags {

These changes should be absorbed into the previous changeset

> revlog.rs:315
> +
> +    // when resolving internal references within revlog, any errors
> +    // should be reported as corruption, instead of e.g. "invalid revision"

This comment should have three leading slashes `///`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11882/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11882

To: aalekseyev, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211210/1609264e/attachment-0002.html>