[Updated] [- ] D11872: upgrade: drop some dead code

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri Dec 10 11:24:28 UTC 2021


marmoute updated this revision to Diff 31411.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D11872?vs=31335&id=31411

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11872/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11872

AFFECTED FILES
  mercurial/upgrade.py

CHANGE DETAILS

diff --git a/mercurial/upgrade.py b/mercurial/upgrade.py
--- a/mercurial/upgrade.py
+++ b/mercurial/upgrade.py
@@ -85,9 +85,6 @@
     )
     removed_actions = upgrade_actions.find_format_downgrades(repo)
 
-    removedreqs = repo.requirements - newreqs
-    addedreqs = newreqs - repo.requirements
-
     # check if we need to touch revlog and if so, which ones
 
     touched_revlogs = set()
@@ -159,20 +156,6 @@
     elif msg_issued >= 1:
         ui.status((b"\n"))
 
-    # check the consistency of the revlog selection with the planned action
-
-    if touched_revlogs != upgrade_engine.UPGRADE_ALL_REVLOGS:
-        incompatible = upgrade_actions.RECLONES_REQUIREMENTS & (
-            removedreqs | addedreqs
-        )
-        if incompatible:
-            msg = _(
-                b'ignoring revlogs selection flags, format requirements '
-                b'change: %s\n'
-            )
-            ui.warn(msg % b', '.join(sorted(incompatible)))
-            touched_revlogs = upgrade_engine.UPGRADE_ALL_REVLOGS
-
     upgrade_op = upgrade_actions.UpgradeOperation(
         ui,
         newreqs,



To: marmoute, #hg-reviewers, Alphare
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211210/a2a59d7f/attachment-0002.html>


More information about the Mercurial-patches mailing list