[Updated] D11882: rhg: fix a crash on non-generaldelta revlogs
Alphare (Raphaël Gomès)
phabricator at mercurial-scm.org
Fri Dec 10 15:22:17 UTC 2021
This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.
I tried to test the series before your last update and it was well in the red (https://foss.heptapod.net/mercurial/mercurial-devel/-/pipelines/30072), and it looks like it's not limited to pure builds. Please test your series through the CI next time.
In D11882#182421 <https://phab.mercurial-scm.org/D11882#182421>, @aalekseyev wrote:
> I don't know about revlog-v1 (it seems there are tests in the tree that are revlog-v1-specific and don't gate against it), but (the lack of) zstd compression is also changing the result, so clearly needs to be guarded against, since it's breaking the --pure build.
> I pushed that change. If you have ideas how to make the test less fragile, those would be appreciated. One possibility is to remove the test of corrupted repo altogether, if you think that's better.
I think we can forgo that test, it's more trouble than it's worth.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D11882/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D11882
To: aalekseyev, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211210/555e1473/attachment-0002.html>
More information about the Mercurial-patches
mailing list