[Updated] D11912: pytype: stop excluding changegroup.py

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> changegroup.py:535
>              if phaseall is not None:
> -                if duprevs:
> -                    duprevs.extend(added)
> +                duplicates = duprevs
> +                if duplicates:

Mhhh now it just looks like nonsensical code. I don't think we should appease Pytype this way

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11912/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11912

To: mharbison72, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211215/62adcfaa/attachment-0002.html>