[Updated] D11912: pytype: stop excluding changegroup.py

[mharbison72 (Matt Harbison)]

mharbison72 added inline comments.

INLINE COMMENTS

> Alphare wrote in changegroup.py:535
> Mhhh now it just looks like nonsensical code. I don't think we should appease Pytype this way

I didn't like it either, so I'll just make it suppression comments.

FTR, I'm a little concerned about all of the suppression comments (in general, not necessarily here) in case the code changes in a way that it is an issue, but the comments hide it.  Also, reusing variables (like `foo = str2bytes(foo)`) tends to confuse PyCharm, which is a shame because it does a really good job of finding issues.  I'm not sure where the sweet spot is.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11912/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11912

To: mharbison72, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211215/78f1a0d7/attachment-0002.html>