[Updated] D11912: pytype: stop excluding changegroup.py

[Alphare (Raphaël Gomès)]

This revision is now accepted and ready to land.
Alphare added inline comments.
Alphare accepted this revision.

INLINE COMMENTS

> mharbison72 wrote in changegroup.py:535
> I didn't like it either, so I'll just make it suppression comments.
> 
> FTR, I'm a little concerned about all of the suppression comments (in general, not necessarily here) in case the code changes in a way that it is an issue, but the comments hide it.  Also, reusing variables (like `foo = str2bytes(foo)`) tends to confuse PyCharm, which is a shame because it does a really good job of finding issues.  I'm not sure where the sweet spot is.

I think these will become easier with the Python 2 removal. We can talk about it more then. :)

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11912/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11912

To: mharbison72, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211217/59950d84/attachment-0002.html>