[Updated] D11912: pytype: stop excluding changegroup.py
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Fri Dec 17 11:10:25 UTC 2021
Closed by commit rHG8843c9a8771b: pytype: stop excluding changegroup.py (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D11912?vs=31497&id=31506
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D11912/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D11912
AFFECTED FILES
mercurial/changegroup.py
tests/test-check-pytype.t
CHANGE DETAILS
diff --git a/tests/test-check-pytype.t b/tests/test-check-pytype.t
--- a/tests/test-check-pytype.t
+++ b/tests/test-check-pytype.t
@@ -10,7 +10,6 @@
probably hiding real problems.
mercurial/bundlerepo.py # no vfs and ui attrs on bundlerepo
-mercurial/changegroup.py # mysterious incorrect type detection
mercurial/chgserver.py # [attribute-error]
mercurial/cmdutil.py # No attribute 'markcopied' on mercurial.context.filectx [attribute-error]
mercurial/context.py # many [attribute-error]
@@ -56,7 +55,6 @@
$ pytype -V 3.6 --keep-going --jobs auto mercurial \
> -x mercurial/bundlerepo.py \
- > -x mercurial/changegroup.py \
> -x mercurial/chgserver.py \
> -x mercurial/cmdutil.py \
> -x mercurial/context.py \
diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py
--- a/mercurial/changegroup.py
+++ b/mercurial/changegroup.py
@@ -350,10 +350,11 @@
def ondupchangelog(cl, rev):
if rev < clstart:
- duprevs.append(rev)
+ duprevs.append(rev) # pytype: disable=attribute-error
def onchangelog(cl, rev):
ctx = cl.changelogrevision(rev)
+ assert efilesset is not None # help pytype
efilesset.update(ctx.files)
repo.register_changeset(rev, ctx)
To: mharbison72, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211217/c21a9c2f/attachment-0002.html>
More information about the Mercurial-patches
mailing list