[Updated] D11941: rhg: Properly format warnings related to ignore patterns

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Mon Dec 20 09:41:33 UTC 2021


This revision now requires changes to proceed.
Alphare added inline comments.
Alphare requested changes to this revision.

INLINE COMMENTS

> status.rs:240
> +                .write_stderr(&format_bytes!(
> +                    b"{}: ignoring invalid syntax '{}'\n",
> +                    format_bytes::Utf8(path.display()),

Is the path guaranteed to be UTF8? This could be any sub-ignore file, couldn't it?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11941/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11941

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211220/2c3392a2/attachment-0002.html>


More information about the Mercurial-patches mailing list