[Commented On] D11942: rhg: Accept different "invalid ignore pattern" error message formatting

[SimonSapin]

SimonSapin added a comment.


  Ideally we’d have a way to parse and validate separate regexps from individual patterns (reporting errors with only the relevant line), then combine them (like in https://twitter.com/thingskatedid/status/1472360823058157569 and the preceding thread). If it’s cheap to combine already-fully-compiled DFAs, maybe the `regex` crate could have an API that takes multiple `Regex` values? In the meantime if we accept some duplicated setup-time work we could validate each pattern with `Regex::new`, report errors individually, throw away successful results and then at the end build the mega-regex from concatenated strings like now.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11942/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11942

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20211220/8e03e3ff/attachment-0002.html>