[Commented On] D9964: rhg: Parse per-repository configuration

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Mon Feb 8 16:46:30 UTC 2021


Alphare added inline comments.

INLINE COMMENTS

> SimonSapin wrote in config.rs:29
> I was not at all thinking of this as a cache. Do you mean we could filter based on `ConfigOrigin`? I had not considered that but yeah it’s probably less fragile. Or, what do you think of having three `Vec`s instead of one? System+user, repo, and CLI layers kept separately.

Currently, the ordering of layers gives us an easy answer to precedence that we lose if we split into multiple `Vec`. I say we keep it this way until we feel that this compromise is not worth it anymore and we need another abstraction layer.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9964/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9964

To: SimonSapin, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210208/e9ad1d1e/attachment-0002.html>


More information about the Mercurial-patches mailing list