[Updated] D9964: rhg: Parse per-repository configuration

[SimonSapin]

SimonSapin added inline comments.

INLINE COMMENTS

> Alphare wrote in config.rs:29
> > With three vecs the precedence logic would be centralized in a method that returns impl Iterator<Item=&ConfigLayer>.
> 
> Right, while it's not particularly harder, I didn't feel like it was needed when adding the config logic. If you think that it'll be frequent enough to query the separate "groups" of layers then by all means, go ahead. :)
> 
> > Which do you mean by keep it this way? With RangeFrom<usize>?
> 
> I meant using a single `Vec`. I am still -1 on using `RangeFrom<usize>`.

It’s not frequent, `combine_with_repo` is the only thing that needs handle these hypothetically-separate vecs separately. And the separation would be purely to make the code simpler and less fragile.

A single vec, do you by with `combine_with_repo` filtering based on `ConfigOrigin`?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9964/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9964

To: SimonSapin, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210208/008e449b/attachment-0002.html>