[Commented On] D9967: rhg: replace command structs with functions

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Tue Feb 9 09:12:41 UTC 2021


Alphare added inline comments.

INLINE COMMENTS

> SimonSapin wrote in cat.rs:22
> I’m not thrilled about silently falling back on panics instead of only when we opt to with `HgError::unimplemented`. Panics indicate that should be fixed and so need to be noticed.

You're probably right. The `catch_unwind` patch would probably be for later to add some user-facing message like what hg does with a link to the bug tracker, etc.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9967/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9967

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210209/c0bc53eb/attachment-0002.html>


More information about the Mercurial-patches mailing list