[Accepted] D10012: rhg: Add support for the blackbox extension

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Fri Feb 19 09:05:25 UTC 2021


Alphare added inline comments.
Alphare accepted this revision.

INLINE COMMENTS

> SimonSapin wrote in blackbox.rs:115
> Oh do you mean that `(glob)` expected output in `.t` files makes it hard to expect a literal `?` character? https://docs.rs/users/0.11.0/users/fn.get_current_username.html says “This function to return `None` if the current user does not exist, which could happen if they were deleted after the program started running.” so I don’t expect this `???` fallback to show up a lot in practice and I think it’s not worth testing it.

I don't think it's worth testing either, I just meant I would have chosen a different set of characters just to avoid confusion. It's not a dealbreaker.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10012/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10012

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210219/0cfe361d/attachment-0002.html>


More information about the Mercurial-patches mailing list