[Commented On] D9728: rhg: use a release-mode executable in tests

SimonSapin phabricator at mercurial-scm.org
Wed Jan 13 10:22:54 UTC 2021


SimonSapin added a comment.


  Yes, having debug assertions enabled when running tests would be valuable, but at the moment they’re already disabled in `hg-cpython` since `setup.py` always runs Cargo with `--release`.
  
  Ideally `setup.py` itself would have two different modes: release when building a Mercurial for end users, and dev when running a test suite or otherwise contributing to Mercurial itself. If running the test suite without Rust optimizations is too slow we can configure the `dev` "profile" to enable optimizations <https://doc.rust-lang.org/cargo/reference/profiles.html>, while keeping other dev configuration.
  
  However I’ll leave touching `setup.py` to another patch :)

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9728/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9728

To: SimonSapin, #hg-reviewers, Alphare, pulkit
Cc: pulkit, Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210113/ea0e682a/attachment-0002.html>


More information about the Mercurial-patches mailing list