[Commented On] D9848: fastexport: committer name should not be quoted

roy (Roy Marples) phabricator at mercurial-scm.org
Fri Jan 22 14:50:45 UTC 2021


roy added a comment.


  Using git to create a fast-import, the comitter is never quoted.
  Again, using git to import a quoted comitter name, preserves the quotes.
  Using git log to display the import, the comitters name appears as "Roy Marples" <roy at marples.name> which just looks wrong.
  
  Other systems that creat a fast-import file such as Fossil don't quote either.
  
  While you might not see any reason to change this as per the specification which I can't argue with, no existing tooling other than hg fastexport actually quotes or understands quotes.
  
  So @joerg.sonnenberger  I respectfully ask why we need to quote here? I see no reason to.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9848/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9848

To: roy, #hg-reviewers
Cc: Alphare, joerg.sonnenberger, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210122/7da6d6c3/attachment-0002.html>


More information about the Mercurial-patches mailing list