[Commented On] D9808: hghave: adjust the definition of `tic` to allow curses tests on Windows

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Sun Jan 24 20:57:47 UTC 2021


mharbison72 added a comment.


  In D9808#149349 <https://phab.mercurial-scm.org/D9808#149349>, @indygreg wrote:
  
  > Shouldn't this patch be checking for the existence of the `windows_curses` package instead?
  
  I don't think so.  The only files `pip install windows_curses` creates besides `*.dist-info/` are `_curses.pyd` and `_curses_panel.pyd`.  With these in place, I can `import curses` in a python REPL, but I can't `import windows_curses`.  (On a related note, I probably need to fix the py2exe config to include this, because I'm seeing explicit includes are needed for the thg installer.)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9808/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9808

To: mharbison72, #hg-reviewers, pulkit
Cc: indygreg, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210124/6cf67cbc/attachment-0002.html>


More information about the Mercurial-patches mailing list