[Commented On] D9853: histedit: don't assign to _ for unused values

[SimonSapin]

SimonSapin added a comment.


  I half-expected this to fail some linter, but I see `tests/test-check-pylint.t` only enables very few checks. Still, it might be good to call unused variables `_unused` with the `_` prefix for intentionally unused?
  
  The repo has some other uses of `_` in deconstructing tuples that might similarly conflict with gettext. I wouldn’t try to go after them all without an automated check but this file has 4 other uses of `mode, _ = state[b'mode']`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9853/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9853

To: durin42, #hg-reviewers
Cc: SimonSapin, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210126/df70d4b3/attachment-0002.html>