[Updated] D10899: censor: extract the part about writing the other revision in a function

Alphare (Raphaël Gomès) phabricator at mercurial-scm.org
Thu Jul 1 08:49:15 UTC 2021


This revision is now accepted and ready to land.
Alphare added inline comments.
Alphare accepted this revision.

INLINE COMMENTS

> rewrite.py:294
> +):
> +    """append a "normal" revision to the index"""
> +    (

Nit: why the quotes around "normal"? I would use "unchanged" to be clearer maybe?

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10899/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10899

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210701/8f5d5936/attachment-0001.html>


More information about the Mercurial-patches mailing list