[Commented On] D10927: dirstate: introduce a symbolic constant for the NONNORMAL marker

[SimonSapin]

SimonSapin added a comment.


  +1 for having a named constant but I’m not sure about the `NONNORMAL` name. For example this `size == -1` is also used together with `state == 'r'` (removed) where it means "was previously `state == 'm'` (merged)". The other use is in `dirstate.normallookup` "Mark a file normal, but possibly dirty" together with `state == 'n'`, which does not match the constant’s doc-comment.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10927/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10927

To: marmoute, #hg-reviewers
Cc: SimonSapin, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210702/87013ef1/attachment-0002.html>