[Accepted] D10953: dirstate: move most of the `remove` logic with dirstatemap `removefile`

SimonSapin phabricator at mercurial-scm.org
Mon Jul 5 04:12:36 UTC 2021


SimonSapin added inline comments.
SimonSapin accepted this revision.

INLINE COMMENTS

> dirstate_map.rs:145
>                  HgPath::new(f.extract::<PyBytes>(py)?.data(py)),
> -                oldstate.extract::<PyBytes>(py)?.data(py)[0]
> -                    .try_into()
> -                    .map_err(|e: HgError| {
> -                        PyErr::new::<exc::ValueError, _>(py, e.to_string())
> -                    })?,
> -                size.extract(py)?,
> +                in_merge.extract::<PyBool>(py)?.is_true(),
>              )

No need to go back and change it here, but I think rust-cpython supports specifying a `PyBool` or even `bool` type directly in the method signature, and takes of the conversion in that case

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10953/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10953

To: marmoute, #hg-reviewers, SimonSapin
Cc: SimonSapin, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210705/c960815a/attachment-0002.html>


More information about the Mercurial-patches mailing list