[Commented On] D10936: cmdutil: fix newandmodified file accounting for --interactive commits

[dploch (Daniel Ploch)]

dploch added a comment.


  In D10936#167716 <https://phab.mercurial-scm.org/D10936#167716>, @Alphare wrote:
  
  > The dates should also be globed, since they depend on system speed and do not provide anything useful to the test.
  
  The dates are explicitly set by `hg commit -d` throughout the entire file more or less; they do not appear dependent on system speed.  I assumed they were specified ascending for some reason; I updated the tail of the file to be consistent with the rest of the file.  If there's no point to the date then it should probably all be glob-ified in a separate change.
  
  > Could you also edit your commit message to contain "`issue6533`"? This way bz will close it automatically in the next release.
  
  Done.
  
  > The change looks good aside from this.

INLINE COMMENTS

> mharbison72 wrote in test-commit-interactive.t:1747
> I’m not familiar with this area of code, so I’d rather someone else queue it. But I want to point out that it’s probably better to replace the hash here with `.`, and restore the glob matching below, based on the comment below about the `#if execbit` block above.

Do you mean to replace the hash with `* (glob)`?  `diff -r <hash>` is output, not a command.
Otherwise done.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10936/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10936

To: dploch, #hg-reviewers, Alphare
Cc: Alphare, mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210707/3fca72b8/attachment-0002.html>