[Changed Subscribers] D11088: dirstate-v2: Introduce a docket file

[marmoute (Pierre-Yves David)]

marmoute added inline comments.

INLINE COMMENTS

> debugcommands.py:997
> +    """show the hash of ignore patterns stored in dirstate if v2,
> +    or nothing for dirstate-v2
> +    """

do you mean `or nothing for distate-v1` ?

> dirstatemap.py:639
> +                    # TODO: use mmap when possible
> +                    data = self._opener.read(self.docket.data_filename())
> +                else:

We should restrict that amount of data-read to docket.data_size, should we not ?

> docket.py:30
> +class DirstateDocket(object):
> +    data_filename_pattern = b'dirstate.%s.d'
> +

We should not use `.d` extension here. There are too many part of Mercurial that assum `.d` is attached to a revlog and that will eventually lead to confusion.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11088/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11088

To: SimonSapin, #hg-reviewers
Cc: marmoute, Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210716/51218ca7/attachment-0002.html>