[Commented On] D11173: dirstate: enforce `possibly_dirty` in `set_tracked`

baymax (Baymax, Your Personal Patch-care Companion) phabricator at mercurial-scm.org
Mon Jul 19 20:04:36 UTC 2021


baymax added a comment.
baymax updated this revision to Diff 29518.


  ✅ refresh by Heptapod after a successful CI run (🐙 💚)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D11173?vs=29477&id=29518

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11173/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11173

AFFECTED FILES
  mercurial/dirstate.py

CHANGE DETAILS

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -478,6 +478,10 @@
         elif not entry.tracked:
             self.normallookup(filename)
             return True
+        # XXX This is probably overkill for more case, but we need this to
+        # fully replace the `normallookup` call with `set_tracked` one.
+        # Consider smoothing this in the future.
+        self.set_possibly_dirty(filename)
         return False
 
     @requires_no_parents_change



To: marmoute, #hg-reviewers, Alphare
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210719/52f6e45d/attachment-0002.html>


More information about the Mercurial-patches mailing list