[Changed Subscribers] D11088: dirstate-v2: Introduce a docket file

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Fri Jul 30 01:32:19 UTC 2021


mharbison72 added inline comments.

INLINE COMMENTS

> dirstatemap.py:666-667
> +                # the actual `.hg/dirstate` file is only affected on close.
> +                st.write(new_docket.serialize())
> +                st.close()
> +                # Remove the old data file after the new docket pointing to

Should this be a try/finally (and also the one in the `else`)?  And is the may-or-may-not-be-closed state handled properly by the callers?

> test-help.t:1011-1012
>                   show the contents of the current dirstate
> +   debugdirstateignorepatternshash
> +                 show the hash of ignore patterns stored in dirstate if v2,
>     debugdiscovery

For some reason, the next line of the help text is missing.  Not sure if that means it's malformed.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11088/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11088

To: SimonSapin, #hg-reviewers
Cc: mharbison72, marmoute, Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210730/e8d29a4b/attachment-0002.html>


More information about the Mercurial-patches mailing list