[Request] [+ ] D10808: verify: use some intermediate variables instead of a multi-liner

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Tue Jun 1 09:54:01 UTC 2021


marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.

REVISION SUMMARY
  This is shorter and easier to read as the indentation remains the same.

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D10808

AFFECTED FILES
  mercurial/verify.py

CHANGE DETAILS

diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -153,11 +153,8 @@
         try:
             p1, p2 = obj.parents(node)
             if p1 not in seen and p1 != self.repo.nullid:
-                self._err(
-                    lr,
-                    _(b"unknown parent 1 %s of %s") % (short(p1), short(node)),
-                    f,
-                )
+                msg = _(b"unknown parent 1 %s of %s") % (short(p1), short(node))
+                self._err(lr, msg, f)
             if p2 not in seen and p2 != self.repo.nullid:
                 self._err(
                     lr,



To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210601/b4f9e804/attachment.html>


More information about the Mercurial-patches mailing list