[Request] [+ ] D10810: verify: use some intermediate variables instead of a multi-liner
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Tue Jun 1 09:54:13 UTC 2021
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
This is shorter and easier to read as the indentation remains the same.
We extract the long message in a module level constant for clarity.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D10810
AFFECTED FILES
mercurial/verify.py
CHANGE DETAILS
diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -38,6 +38,11 @@
return f
+HINT_FNCACHE = _(
+ b'hint: run "hg debugrebuildfncache" to recover from corrupt fncache\n'
+)
+
+
class verifier(object):
def __init__(self, repo, level=None):
self.repo = repo.unfiltered()
@@ -202,12 +207,7 @@
if self.warnings:
ui.warn(_(b"%d warnings encountered!\n") % self.warnings)
if self.fncachewarned:
- ui.warn(
- _(
- b'hint: run "hg debugrebuildfncache" to recover from '
- b'corrupt fncache\n'
- )
- )
+ ui.warn(HINT_FNCACHE)
if self.errors:
ui.warn(_(b"%d integrity errors encountered!\n") % self.errors)
if self.badrevs:
To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210601/7b34d9b8/attachment-0001.html>
More information about the Mercurial-patches
mailing list