[Request] [+ ] D10818: verify: use some intermediate variables instead of a multi-liner
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Tue Jun 1 09:54:58 UTC 2021
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
This is shorter and easier to read as the indentation remains the same.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D10818
AFFECTED FILES
mercurial/verify.py
CHANGE DETAILS
diff --git a/mercurial/verify.py b/mercurial/verify.py
--- a/mercurial/verify.py
+++ b/mercurial/verify.py
@@ -514,11 +514,8 @@
if problem.warning:
self._warn(problem.warning)
elif problem.error:
- self._err(
- linkrev if linkrev is not None else lr,
- problem.error,
- f,
- )
+ linkrev_msg = linkrev if linkrev is not None else lr
+ self._err(linkrev_msg, problem.error, f)
else:
raise error.ProgrammingError(
b'problem instance does not set warning or error '
To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210601/2188a08f/attachment.html>
More information about the Mercurial-patches
mailing list