[Commented On] D10782: revlog: use `self.sidedata` directly in `revlog.clone`

[baymax (Baymax, Your Personal Patch-care Companion)]

baymax added a comment.
baymax updated this revision to Diff 28392.


  ✅ refresh by Heptapod after a successful CI run (🐙 💚)

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D10782?vs=28295&id=28392

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10782/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10782

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -3109,7 +3109,8 @@
             cachedelta = None
             rawtext = None
             if deltareuse == self.DELTAREUSEFULLADD:
-                text, sidedata = self._revisiondata(rev)
+                text = self._revisiondata(rev)[0]
+                sidedata = self.sidedata(rev)
 
                 if sidedata_helpers is not None:
                     (sidedata, new_flags) = sidedatautil.run_sidedata_helpers(
@@ -3137,7 +3138,8 @@
 
                 sidedata = None
                 if not cachedelta:
-                    rawtext, sidedata = self._revisiondata(rev)
+                    rawtext = self._revisiondata(rev)[0]
+                    sidedata = self.sidedata(rev)
                 if sidedata is None:
                     sidedata = self.sidedata(rev)
 



To: marmoute, indygreg, #hg-reviewers, Alphare
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210602/f0bfb2c6/attachment-0001.html>