[Request] [+ ] D10846: transaction: simplify `undo.backupfiles` file creation with a variable
marmoute (Pierre-Yves David)
phabricator at mercurial-scm.org
Wed Jun 9 14:37:33 UTC 2021
marmoute created this revision.
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-patches.
REVISION SUMMARY
This make the code shorter and clearer.
(This is an opportunity improvement while looking at something next to that.)
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D10846
AFFECTED FILES
mercurial/transaction.py
CHANGE DETAILS
diff --git a/mercurial/transaction.py b/mercurial/transaction.py
--- a/mercurial/transaction.py
+++ b/mercurial/transaction.py
@@ -633,9 +633,9 @@
"""write transaction data for possible future undo call"""
if self._undoname is None:
return
- undobackupfile = self._opener.open(
- b"%s.backupfiles" % self._undoname, b'w'
- )
+
+ undo_backup_path = b"%s.backupfiles" % self._undoname
+ undobackupfile = self._opener.open(undo_backup_path, b'w')
undobackupfile.write(b'%d\n' % version)
for l, f, b, c in self._backupentries:
if not f: # temporary file
To: marmoute, #hg-reviewers
Cc: mercurial-patches, mercurial-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210609/63b7399b/attachment-0001.html>
More information about the Mercurial-patches
mailing list