[Changed Subscribers] D10827: dirstate-v2: Write .hg/dirstate back to disk on directory cache changes

[Alphare (Raphaël Gomès)]

Alphare added inline comments.

INLINE COMMENTS

> status.rs:83
>      let to_add = common.cached_directory_mtimes_to_add.into_inner().unwrap();
> +    outcome.dirty = !to_add.is_empty();
>      for (path, mtime) in &to_add {

This does not seem semantically correct. The docstring for `dirty` says that it's any change to the dirstate that should be written, but this only concerns the directories cache.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10827/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10827

To: SimonSapin, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210602/f2e8c0b1/attachment-0002.html>