[Commented On] D10296: rhg: read [paths] for `--repository` value

[SimonSapin]

SimonSapin added inline comments.

INLINE COMMENTS

> main.rs:187
> +                        ];
> +                        Config::load_from_explicit_sources(config_files).ok()
> +                    } else {

`.ok()` here together with the handling of `None` later silently ignore config parse errors, where Python-based hg aborts. However:

- This is a rather niche corner case
- Handling such errors in this particular function is tricky because we can’t just use the `?` operator
- This patch still improves things already, and has been open long enough

So please add a `// TODO: handle errors from `load_from_explicit_sources` comment and let’s follow up later.

Similarly please add a TODO comment above for handling errors from `current_dir`

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10296/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10296

To: pulkit, #hg-reviewers, Alphare, SimonSapin
Cc: marmoute, SimonSapin, Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210607/59874cdf/attachment-0002.html>