[Updated] D10873: py3: byteify the version string passed to the deprecation warning method

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Tue Jun 15 18:56:55 UTC 2021


Closed by commit rHGc887bab2dccf: py3: byteify the version string passed to the deprecation warning method (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D10873?vs=28556&id=28583

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10873/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10873

AFFECTED FILES
  mercurial/localrepo.py
  mercurial/ui.py
  mercurial/utils/urlutil.py

CHANGE DETAILS

diff --git a/mercurial/utils/urlutil.py b/mercurial/utils/urlutil.py
--- a/mercurial/utils/urlutil.py
+++ b/mercurial/utils/urlutil.py
@@ -688,7 +688,7 @@
         path to a repo.
         """
         msg = b'getpath is deprecated, use `get_*` functions from urlutil'
-        ui.deprecwarn(msg, '6.0')
+        ui.deprecwarn(msg, b'6.0')
         # Only fall back to default if no path was requested.
         if name is None:
             if not default:
diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -1065,7 +1065,7 @@
         This method exist as `getpath` need a ui for potential warning message.
         """
         msg = b'ui.getpath is deprecated, use `get_*` functions from urlutil'
-        self.deprecwarn(msg, '6.0')
+        self.deprecwarn(msg, b'6.0')
         return self.paths.getpath(self, *args, **kwargs)
 
     @property
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -2759,7 +2759,7 @@
                 "`full` argument for `repo.updatecaches` is deprecated\n"
                 "(use `caches=repository.CACHE_ALL` instead)"
             )
-            self.ui.deprecwarn(msg, "5.9")
+            self.ui.deprecwarn(msg, b"5.9")
             caches = repository.CACHES_ALL
             if full == b"post-clone":
                 caches = repository.CACHES_POST_CLONE



To: mharbison72, #hg-reviewers, Alphare
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210615/e1829158/attachment-0002.html>


More information about the Mercurial-patches mailing list