[Updated] D10878: revlog: Extract low-level random-access file read caching logic

[Alphare (Raphaël Gomès)]

This revision is now accepted and ready to land.
Alphare added inline comments.
Alphare accepted this revision.

INLINE COMMENTS

> revlog.py:92
>  )
> +from .revlogutils import randomaccessfile
>  from .utils import (

I forgot this on the first pass, but this should be grouped with the other import from revlogutils. I will change that in flight

> Alphare wrote in randomaccessfile.py:15
> We should add an assertion with a comment explaining that we do some bit-wise magic afterwards that depends on it being a power of two.

For posterity, this was not the right constant for this comment, but the assertion was added.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10878/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10878

To: SimonSapin, indygreg, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210617/a42f4885/attachment-0002.html>