[Updated] D10866: revlog: add a way to keep track of older uids in the docket

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri Jun 18 10:17:21 UTC 2021


marmoute added inline comments.

INLINE COMMENTS

> Alphare wrote in docket.py:144
> Aren't those asserts kind of overkill? I don't mind keeping this, but I'm wondering if there is a better chance of this happening than I imagine

They are no reason for them to arrive except when the serialization/deserialization code is wrong. In that case, it is nice to have a clear error about the issue. We could drop them, but they are cheap and might help while developing future patch.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10866/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10866

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210618/c9e35c3e/attachment-0002.html>


More information about the Mercurial-patches mailing list