[Updated] D10884: ui: add a context manager for silencing the ui (pushbuffer+popbuffer)

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In D10884#166556 <https://phab.mercurial-scm.org/D10884#166556>, @Alphare wrote:
  
  > This revision breaks `test-check-imports.t`, please follow-up.
  
  Hmm, sorry about that. I noticed that it was failing, but it has been failing since D10513 <https://phab.mercurial-scm.org/D10513> for me. This is how it fails for me:
  
    --- /usr/local/google/home/martinvonz/hg/tests/test-check-module-imports.t
    +++ /usr/local/google/home/martinvonz/hg/tests/test-check-module-imports.t.err
    @@ -42,3 +42,10 @@
       > -X tests/test-imports-checker.t \
       > -X tests/test-verify-repo-operations.py \
       > | sed 's-\\-/-g' | "$PYTHON" "$import_checker" -
    +  tests/test-convert-bzr.t:117: imports not lexically sorted: breezy.bzr.bzrdir < sys
    +  tests/test-convert-bzr.t:117: stdlib import "breezy.bzr.bzrdir" follows local import: breezy
    +  tests/test-convert-bzr-ghosts.t:7: imports not lexically sorted: breezy.bzr.bzrdir < sys
    +  tests/test-convert-bzr-ghosts.t:7: stdlib import "breezy.bzr.bzrdir" follows local import: breezy
    +  tests/test-convert-bzr-treeroot.t:7: imports not lexically sorted: breezy.bzr.bzrdir < sys
    +  tests/test-convert-bzr-treeroot.t:7: stdlib import "breezy.bzr.bzrdir" follows local import: breezy
    +  [1]
    
    ERROR: test-check-module-imports.t output changed
  
  Does it fail in some other way for you?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10884/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10884

To: martinvonz, durin42, #hg-reviewers, pulkit
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210621/b9b41378/attachment-0002.html>