[Commented On] D10893: amend: add a useless initial version of `amend -r REV `

[Alphare (Raphaël Gomès)]

Alphare added a comment.


  This is indeed a very important quality-of-life feature and I'm +1 on adding it to Mercurial.
  
  I have a few questions/remarks however:
  
  - Just to make sure we're on the same page, you're suggesting to auto-rebase the stack i.e. what's between the commit to amend and the current working directory parent and nothing more, right? We probably want a non-default mode without the auto-rebase, I can see that being useful.
  - I remember sprint discussions wherein people warned that the semantics of `--rev` were not clear in the context of `amend` and suggested using something like `--into-rev`. I personally think `--rev` feels natural to me and I don't have strong objections to using it, but we should maybe ask the community (with a poll?) and keep the option open while implementing it.
  - Maybe plug into `hg continue/abort` and suggest using it first, then `hg amend --continue/abort`?
  
  As a nit, I'd say the `.t` test should be using `(known-bad-output !)` and/or `(missing-correct-output !)` to better signal what is expected than the TODO.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10893/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10893

To: martinvonz, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210622/57afa5b0/attachment-0002.html>