[Commented On] D10894: benchmarks: restore `output` variable lost in D10884

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In D10894#166664 <https://phab.mercurial-scm.org/D10894#166664>, @Alphare wrote:
  
  > Doesn't this lose the `ui.silent` feature?
  
  No, the pushbuffer+popbuffer sequence was very often used for silencing the ui, but that wasn't the (only) reason here -- the output is actually used for something. This is (AFAIK) what pushbuffer+popbuffer *should* be used for. I just missed that the output was used here when I wrote D10884 <https://phab.mercurial-scm.org/D10884>.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10894/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10894

To: martinvonz, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210622/4d3ccf67/attachment-0002.html>