[Commented On] D10917: rewriteutil: check for divergence on unfiltered repo

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In D10917#166940 <https://phab.mercurial-scm.org/D10917#166940>, @marmoute wrote:
  
  > In D10917#166939 <https://phab.mercurial-scm.org/D10917#166939>, @martinvonz wrote:
  >
  >> In D10917#166937 <https://phab.mercurial-scm.org/D10917#166937>, @marmoute wrote:
  >>
  >>> It does not looks like this is done at the right level. The code responsible for the processors walking should be the one adjusting the filter level.
  >>
  >> Which code is that? Do you mean that it should be done at a higher or lower level?
  >
  > lower level
  
  I still don't understand. Do you mean that `find_new_divergence_from()` should not return filtered nodeids?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10917/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10917

To: martinvonz, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210630/a564bdc1/attachment-0002.html>