[Updated] D9844: revlogv2: allow upgrading to v2

[marmoute (Pierre-Yves David)]

This revision now requires changes to proceed.
marmoute added inline comments.
marmoute requested changes to this revision.

INLINE COMMENTS

> configitems.py:1295-1302
> +
> +# Right now, the only efficient implement of the nodemap logic is in Rust, so
> +# the persistent nodemap feature needs to stay experimental as long as the Rust
> +# extensions are an experimental feature.
> +coreconfigitem(
> +    b'format', b'use-persistent-nodemap', default=False, experimental=True
> +)

This whole part seems like a mistake during a merge. We should drop it.

> actions.py:378-384
>  @registerformatvariant
> +class revlogv2(requirementformatvariant):
> +    name = b'revlog-v2'
> +    _requirement = requirements.REVLOGV2_REQUIREMENT
> +    default = False
> +    description = _(b'Version 2 of the revlog.')
> +    upgrademessage = _(b'very experimental')

if `revlogv2 <=> sidedata`, we should replace the associate format variant with this new one on adding a "duplicated" one.

> actions.py:898
> +    """Check that the requirements contain at least one Revlog version"""
> +    all_revlogs = {b'revlogv1', requirements.REVLOGV2_REQUIREMENT}
> +    if not all_revlogs.intersection(reqs):

revlogv1 should move to a constant for clarity/cleaness. Can you do that as preparatory changesets?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D9844/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D9844

To: Alphare, #hg-reviewers, marmoute
Cc: marmoute, pulkit, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210302/51949452/attachment.html>