[Commented On] D10083: tags: validate nodes in _getfnodes() and update cache in case of unknown nodes

[marmoute (Pierre-Yves David)]

marmoute added inline comments.

INLINE COMMENTS

> tags.py:504-505
> +                try:
> +                    repo.filectx(b'.hgtags', fileid=fnode).data()
> +                    validated_fnodes.add(fnode)
> +                except error.LookupError:

look slike my main an long comment about this got lost…

I don't understand why we do a full filectx initialisation and data fetch here. What we want to do is only check if the node exist within the filelog. right? Why won't we explicitly grab de filelog and check that?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10083/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10083

To: pulkit, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210302/29a51a81/attachment-0002.html>