[Changed Subscribers] D10104: pure-parsers: document index class constants

SimonSapin phabricator at mercurial-scm.org
Thu Mar 4 09:15:38 UTC 2021


SimonSapin added inline comments.

INLINE COMMENTS

> parsers.py:51-52
>      int_size = struct.calcsize(b'i')
> +    # Size of the entire index format on this platform
>      index_size = struct.calcsize(index_format)
> +    # An empty index entry, used as a default value to be overridden, or nullrev

This description isn’t factually wrong, but wouldn’t it be a serious bug if the on-disk format ends up varying across different platforms?

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10104/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10104

To: Alphare, #hg-reviewers, pulkit
Cc: SimonSapin, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210304/e8240dee/attachment-0002.html>


More information about the Mercurial-patches mailing list