[Commented On] D10115: copies: choose target directory based on longest match

[marmoute (Pierre-Yves David)]

marmoute added a comment.


  In D10115#154172 <https://phab.mercurial-scm.org/D10115#154172>, @martinvonz wrote:
  
  > In D10115#154171 <https://phab.mercurial-scm.org/D10115#154171>, @marmoute wrote:
  >
  >> Yeah I meant 'a', sorry about that (the 'd' comes from a copies discussion I had with Pulkit in //). Line 192 does not help me much since we still seems to be sorting the longest first as far as I undersant (which result in the deepest coming first).
  >
  > I guess I still don't know what your question is then. You said something about this change altering behavior. What I didn't understand is how you think it alters the behavior. Can you elaborate?
  
  My question was "If you change the ordering, are we sure we don't break things break previous behavior that could make sense?"
  
  >> However it seems like we were previously interating over a dictionnary so we unstable order, right ?
  >
  > Yes.
  
  Since the previous ordering seems to be "no stable ordering" I don't think this diff could have break any behavior relying on it ☺

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10115/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10115

To: martinvonz, #hg-reviewers, pulkit
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210309/1a16d383/attachment-0002.html>