[Updated] D10487: dirstate-tree: Maintain a counter of DirstateEntry’s and copy sources
SimonSapin
phabricator at mercurial-scm.org
Mon May 3 09:51:40 UTC 2021
SimonSapin added inline comments.
INLINE COMMENTS
> Alphare wrote in dirstate_map.rs:125
> I'd have used a dedicated enum, but this is fine for a private function.
Yeah, itâs not great, but a later refactor removes that parameter anyway (pushes its handling to callers).
I could potentially backport that change to simplify review, but itâs not trivial because thereâs a number of other changesets in-between.
REPOSITORY
rHG Mercurial
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D10487/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D10487
To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210503/a18b27e5/attachment.html>
More information about the Mercurial-patches
mailing list