[Updated] D10491: dirstate-tree: Add add_file, remove_file, and drop_file

[SimonSapin]

SimonSapin added inline comments.

INLINE COMMENTS

> Alphare wrote in dirstate_map.rs:338
> Maybe leave a comment saying why `old_state` isn't useful in this implementation.

A later commit “//dirstate-tree: Fold "tracked descendants" counter update in main walk//” ends up using it. (The same info is already in the tree, but having it available before tree lookup enables some optimization.)

> Alphare wrote in dirstate_map.rs:368
> I think we should remove it from the tree.

I agree. I’ll do that in a future separate patch.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10491/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10491

To: SimonSapin, #hg-reviewers
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20210503/2707bdb9/attachment.html>