[Commented On] D10703: Fix hgext/convert/p4.py for Python 3

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Mon May 10 03:36:17 UTC 2021


mharbison72 added a comment.


  In D10703#162603 <https://phab.mercurial-scm.org/D10703#162603>, @nate wrote:
  
  > Corrected. That works just as well.
  > I couldn't recall how to embed a message along with a patch. message+patch file concatenation?
  
  Typically, you just commit and put everything in the commit message, and then `hg phabsend .`
  
  It's not letting me import this patch for some reason, complaining about "failing to synchronize the metadata".  How did you create this differential?  Since it's trivial, I can just fix it up for you, but do you have a name and email address to apply to this?
  
  > Not sure what topic and other fields/tags I should fill. Not to sound abrasive: I don't really have the time among millions of lines of code.
  > Given "Patch descriptions should be aimed at helping the reviewer understand the issue you're addressing.", I hope my title was descriptive enough. The best I can think is "dict.keys() doesn't have a sort method in python 3".
  
  Don't worry about this, I'll adjust it.  I only pointed it out because the automated tests will complain if the first line isn't in the proper "topic: lowercase words..." format, and the guidelines probably aren't easy enough for new contributors to find.  Let me know what name/email to apply, and I'll land this for you.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10703/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10703

To: nate, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210510/8736f176/attachment-0002.html>


More information about the Mercurial-patches mailing list