[Updated] D10714: transaction: trivial refactoring

valentin.gatienbaron (Valentin Gatien-Baron) phabricator at mercurial-scm.org
Sun May 23 22:05:52 UTC 2021


Closed by commit rHG13dd5bb5492a: transaction: trivial refactoring (authored by valentin.gatienbaron).
This revision was automatically updated to reflect the committed changes.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D10714?vs=28158&id=28184

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10714/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10714

AFFECTED FILES
  mercurial/transaction.py

CHANGE DETAILS

diff --git a/mercurial/transaction.py b/mercurial/transaction.py
--- a/mercurial/transaction.py
+++ b/mercurial/transaction.py
@@ -720,9 +720,8 @@
     entries = []
     backupentries = []
 
-    fp = opener.open(file)
-    lines = fp.readlines()
-    fp.close()
+    with opener.open(file) as fp:
+        lines = fp.readlines()
     for l in lines:
         try:
             f, o = l.split(b'\0')



To: valentin.gatienbaron, #hg-reviewers, pulkit
Cc: mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210523/a9a0f26e/attachment-0002.html>


More information about the Mercurial-patches mailing list