[Commented On] D10768: upgrade: Use `improvement` subclasses everywhere, not instances

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Wed May 26 09:15:42 UTC 2021


marmoute added inline comments.

INLINE COMMENTS

> SimonSapin wrote in actions.py:49-90
> This docstring used to document instance attributes, but instances attributes aren’t used anymore. Class attributes already have individual comments in the base class definition with mostly the same content.
> 
> I had missed that `touches_*` class attributes were not documented individually, I’ll restore that (even though these comments are not doing much besides paraphrasing what the attribute names are already saying).

okay, thanks for the explanation.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10768/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10768

To: SimonSapin, #hg-reviewers, marmoute
Cc: marmoute, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210526/f4b2d5ca/attachment-0002.html>


More information about the Mercurial-patches mailing list