[Updated] D10749: dirstate-v2: Make more APIs fallible, returning Result

[Alphare (Raphaël Gomès)]

This revision is now accepted and ready to land.
Alphare added inline comments.
Alphare accepted this revision.

INLINE COMMENTS

> SimonSapin wrote in dirstate.rs:80
> Oh I hadn’t checked what rustfmt had done to this. Do you think it’d be better with separate `type` definitions for iterated items, in order to keep each definition on one line?

I don't think it matters too much as far as I'm concerned, but some people might argue the opposite. They can send a patch ;)

> status.rs:121
> +        // callback below
> +        for dirstate_node in &dirstate_nodes {
> +            dirstate_node.base_name()?;

I wonder if the compiler will optimize the two loops somehow. But we can take a look at this in the profiling phase, later.

REPOSITORY
  rHG Mercurial

BRANCH
  default

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D10749/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D10749

To: SimonSapin, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20210531/38a29a46/attachment-0002.html>