[Updated] D11722: rhg: implement the debugignorerhg subcommand

[Alphare (Raphaël Gomès)]

This revision now requires changes to proceed.
Alphare added a comment.
Alphare requested changes to this revision.


  Thanks for waiting for so long. 6.0 is out (it was delayed a lot for Windows reasons), so I'll be back to reviewing patches for default.

INLINE COMMENTS

> matchers.rs:604
> +) -> PatternResult<(
> +    Box<dyn for<'r> Fn(&'r HgPath) -> bool + Sync + 'a>,
> +    Vec<PatternFileWarning>,

It would be nice to have a type alias for this (and the one below). We already have one in `hg-core/src/dirstate/status.rs`, probably should be refactored.

> debugignorerhg.rs:17
> +pub fn args() -> clap::App<'static, 'static> {
> +    SubCommand::with_name("debugignorerhg").about(HELP_TEXT)
> +}

nit: we prefer new commands to have dashes in them now, but it's really not a big deal since this is temporary anyway

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11722/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11722

To: aalekseyev, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20211124/eec79f20/attachment.html>