[Commented On] D11722: rhg: implement the debugignorerhg subcommand

aalekseyev (Arseniy Alekseyev) phabricator at mercurial-scm.org
Fri Nov 26 19:49:39 UTC 2021


aalekseyev added inline comments.

INLINE COMMENTS

> Alphare wrote in matchers.rs:604
> It would be nice to have a type alias for this (and the one below). We already have one in `hg-core/src/dirstate/status.rs`, probably should be refactored.

I used the alias from status.rs now.

> Alphare wrote in debugignorerhg.rs:17
> nit: we prefer new commands to have dashes in them now, but it's really not a big deal since this is temporary anyway

I'm not sure how to do that, actually. I tried renaming the command to debugignorerhg, but got an error:

  468 |     debugignore-rhg
      |                ^ no rules expected this token in macro call

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D11722/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D11722

To: aalekseyev, #hg-reviewers, Alphare
Cc: Alphare, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mercurial-scm.org/pipermail/mercurial-patches/attachments/20211126/4be627a4/attachment.html>


More information about the Mercurial-patches mailing list